fix(gorgone): Fixes around db transaction handling #1582

vuntz · 2024-07-27T20:08:02Z

Description

See each individual commits for the details

Fixes #MON-58184, #MON-48768

Type of change

Patch fixing an issue (non-breaking change)
New functionality (non-breaking change)
Breaking change (patch or feature) that might cause side effects breaking part of the Software
Updating documentation (missing information, typo...)

Target serie

…tocommit

…s ends the transaction

… end transaction manually

…s is attempted

coderabbitai · 2024-07-27T20:08:12Z

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)

coderabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Evan-Adam

I have a doubt on the begin_transaction() sub called in sqlquery line 140, the rest is optionnal.

Evan-Adam · 2024-08-05T12:43:10Z

gorgone/gorgone/class/db.pm

-        my $status = $self->{instance}->commit();
-        $self->{transaction_begin} = 0;
+    if (!defined($self->{instance})) {
+        $self->transaction_cleanup();


Can you add a log here or in the transaction_cleanup() sub so users know why it failed ?

Suggested change

$self->transaction_cleanup();

$self->transaction_cleanup();

$self->{logger}->writeLogError("Database connection is not defined, please check configuration and database health.");

Evan-Adam · 2024-08-05T12:47:39Z

gorgone/gorgone/class/db.pm

@@ -319,7 +341,7 @@ sub error {
 Query: $query
 ";
    $self->{logger}->writeLogError($error);
-    if ($self->{transaction_begin} == 1) {
+    if ($self->{in_transaction} == 1) {


Seem strange to me that error() call rollback() which can call error()
maybe you can delete one of the 2 function ?
I haven't tested but maybe this error() sub should call $self->{instance}->rollback() instead ?

Evan-Adam · 2024-08-05T12:51:29Z

gorgone/gorgone/class/sqlquery.pm

    my ($self) = @_;

-    return $self->{db_centreon}->transaction_mode($_[1]);
+    return $self->{db_centreon}->begin_transaction();


you changed the function transaction_mode to start_transaction in db.pm, where does begin_transaction is defined ?

vuntz added 9 commits July 27, 2024 07:13

fix(gorgone): Check if there's a db connection before checking for au…

6481690

…tocommit

fix(gorgone): Re-enable db autocommit on commit/rollback since this i…

d9eda97

…s ends the transaction

fix(gorgone): Clear the transaction flag when connecting to the database

649d969

fix(gorgone): Cleanup db code so that callers know they don't need to…

a61ce46

… end transaction manually

fix(gorgone): Rollback db transaction when commit fails

e045225

fix(gorgone): Make commit/rollback return if no transaction is started

d78d1d1

cleanup(gorgone): Rename transaction_begin to in_transaction for clarity

d15b700

cleanup(gorgone): Avoid double-rollback when db commit fails

0716eb2

fix(gorgone): Do not accept nested db transactions, and fail when thi…

ff7cc2a

…s is attempted

vuntz requested a review from a team as a code owner July 27, 2024 20:08

vuntz requested a review from lucie-dubrunfaut July 27, 2024 20:08

Evan-Adam requested changes Aug 5, 2024

View reviewed changes

bouda1 force-pushed the develop branch from d763134 to ce58da6 Compare October 3, 2024 16:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(gorgone): Fixes around db transaction handling #1582

fix(gorgone): Fixes around db transaction handling #1582

vuntz commented Jul 27, 2024

coderabbitai bot commented Jul 27, 2024

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Evan-Adam left a comment

Evan-Adam Aug 5, 2024

Evan-Adam Aug 5, 2024

Evan-Adam Aug 5, 2024

	$self->transaction_cleanup();
	$self->transaction_cleanup();
	$self->{logger}->writeLogError("Database connection is not defined, please check configuration and database health.");

fix(gorgone): Fixes around db transaction handling #1582

Are you sure you want to change the base?

fix(gorgone): Fixes around db transaction handling #1582

Conversation

vuntz commented Jul 27, 2024

Description

Type of change

Target serie

coderabbitai bot commented Jul 27, 2024

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Evan-Adam left a comment

Choose a reason for hiding this comment

Evan-Adam Aug 5, 2024

Choose a reason for hiding this comment

Evan-Adam Aug 5, 2024

Choose a reason for hiding this comment

Evan-Adam Aug 5, 2024

Choose a reason for hiding this comment

CodeRabbit Configuration File (`.coderabbit.yaml`)